Achievement
- Reduce the time on this project recently.
- Remove most nullable disable annotation in the main project.
- Back to the office ;_;
- ๅไธป็ฎก่จ่ซ็่ทๅ่ชใๅฆๆ้้็่ฉฑ๏ผๆฅไธๅฐฑ่ฝๆดๆๆดๅค็ๆ้ๅ ๆ้ไปฝๅฐๆกๅผๅฐไธๅๆฎต่ฝ๏ผ้ๆๅนดๅบ็ๆฅๆฌๆ ้ๅฐฑๆ่่ฝไบใ
Beatmap
Ruby
/Romaji
’s index should be the char index. karaoke- Should adjust the lyric parser first.
- Then, make the font framework happy. font-package
- Finally, adjust the main project. karaoke
Code quality
Use
= null!
to replace the[AllowNull]
attribute. karaoke
Change this:[Resolved, AllowNull] private EditorBeatmap beatmap { get; set; }
Into this:
[Resolved] private EditorBeatmap beatmap { get; set; } = null!;
Remove the nullable disable annotation in some location:
- Remove the nullable disable annotation in the
editor
. karaoke - Remove the nullable disable annotation in the
overlay
namespace. karaoke - Remove the nullable disable annotation in the
UI
namespace. karaoke - Remove the nullable disable annotation in the
Statistics
namespace. karaoke - Remove the nullable disable annotation in the
setting page
. karaoke - Remove the nullable disable annotation in the
skin editor
. karaoke - Remove the nullable disable annotation in the
lyric editor
. karaoke - Remove the nullable disable annotation in the
import lyric
namespace. karaoke - Remove the nullable disable annotation in the
singer editor
. karaoke - Remove the nullable disable annotation in the
whole beatmap editor
. karaoke
- Remove the nullable disable annotation in the
Adjust
permit null
in dependency injection. karaokeRemove all
aaa.invoke()
usage. karaoke
Editor
OpacityButton
should have thecurrent
property like other shared component. karaoke- Separate the base class for those “lyric index” based caret position algorithm. karaoke
For now, we have two lyric text-based caret position algorithm:CharGapCaretPositionAlgorithm
: adjust the caret index between text gap.CharIndexCaretPositionAlgorithm
: adjust the caret index between chars.
- Combine the
Validate
andPositionMovable
in theCaretPositionAlgorithm
because pre-validator in the caret position algorithm usually check the same things as whatPositionMovable
did. karaoke - Algorithm should not accept the null caret position index. karaoke
- Implement base interface for able to change the end index caret position. karaoke
Setting
- Fix the broken preview area in the setting menu. karaoke
- Fix cannot open the karaoke config page. karaoke
- Remove assign language in the main setting overlay because does not have the global popover container now. karaoke
UI/UX
- Make language selector able to select null language. karaoke